New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only clean def files if they are 'packageName.def' #1161

Merged
merged 3 commits into from Jun 2, 2016

Conversation

Projects
None yet
3 participants
@jimhester
Member

jimhester commented Apr 27, 2016

The clean patterns are originally from R CMD build (https://github.com/wch/r-source/blob/4ba41332b405f29569dad311f36500391fe6f41f/src/library/tools/R/build.R#L406-L433), which @hadley referenced in the original PR (#137 (comment))

The previous behavior was too loose, only def files with the package name should be cleaned.

The same is true for .a and .dll as well, however @wch thought there may be cases we do need to clean all of them.

Fixes #1159
cc @jeroenooms

@wch

This comment has been minimized.

Member

wch commented Apr 27, 2016

Now that I've thought about it some more, I think it's probably better to remove only the pkgname.a and pkgname.dll files instead of *.a and *.dll.

@jimhester jimhester added this to the 1.11.2 milestone May 31, 2016

@hadley hadley merged commit 954c08d into r-lib:master Jun 2, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment