New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github URLs may lack trailing `.git` #1253

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jennybc
Member

jennybc commented Jul 5, 2016

Apparently Github URLs don't require the trailing .git. I verified that you can use the plain browser URL in git clone and RStudio New Project > Version Control ... and everything works just fine. Until you call use_travis(), use_coverage(), etc., where the current regex will fail to extract username and repo. The fact you can push and pull with the browser URL "for services like GitHub" even shows up in the Smart HTTP section of Pro Git.

@jimhester

This comment has been minimized.

Member

jimhester commented Jul 11, 2016

You can avoid perl = TRUE with

"github[^/:]*[/:]([^/]+)/(.*?)(?:\\.git)?$"

Which also works in all your test cases.

@jennybc

This comment has been minimized.

Member

jennybc commented Jul 11, 2016

Wish I'd thought of that. OK I upgraded w/ your regex and dropped perl = TRUE.

@hadley

This comment has been minimized.

Member

hadley commented Nov 3, 2016

Could you please add a bullet to NEWS?

@jennybc

This comment has been minimized.

Member

jennybc commented Nov 3, 2016

Bullet added (and rebased).

@hadley hadley closed this in d5d9846 Nov 4, 2016

@jennybc jennybc deleted the jennybc:generalize-github-remote branch Nov 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment