New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load test helpers twice in test() #1256

Merged
merged 2 commits into from Jul 8, 2016

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented Jul 8, 2016

requires testthat >= 1.0.3 (r-lib/testthat#505).

Kirill Müller added some commits Jul 8, 2016

Kirill Müller
don't load helpers twice
requires testthat >= 1.0.3
Kirill Müller

@hadley hadley merged commit c323994 into r-lib:master Jul 8, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jul 8, 2016

Thanks!

@jimhester

This comment has been minimized.

Member

jimhester commented Jul 8, 2016

The testthat PR needs to be merged and testthat needs to add testthat to Remotes:, or that PR needs to be added to Remotes to avoid breaking devtools.

@krlmlr krlmlr deleted the krlmlr:f-test-env branch Jul 8, 2016

krlmlr pushed a commit to krlmlr/devtools that referenced this pull request Jul 31, 2016

Kirill Müller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment