New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying to move vignette sources twice #1291

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@flying-sheep
Contributor

flying-sheep commented Aug 17, 2016

Sometimes multiple vignettes can share source files. This breaks the file.remove call which expects unique arguments.


the way i encountered this is that tools::pkgVignettes has two bugs:

  1. it loops over all vignette engines (tools::loadVignetteBuilder results in a hardcoding sweave as last engine) and sets engine to the last one looped (=always sweave)
  2. tools:::find_vignette_product is called with that engine and finds all r scripts in the directory prefixed with that name.

this results in duplicated source entries if a vignette’s file name is a prefix of another.

@hadley

This comment has been minimized.

Member

hadley commented Nov 3, 2016

Could you please add a bullet to NEWS?

flying-sheep added some commits Aug 17, 2016

Avoid trying to move vignette sources twice
Sometimes multiple vignettes can share source files. This breaks the `file.remove` call which expects unique arguments.

@jimhester jimhester added this to the 1.13.0 milestone May 3, 2017

@jimhester

This comment has been minimized.

Member

jimhester commented May 17, 2017

Thanks! Merged in 72b1926

@jimhester jimhester closed this May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment