New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture installation output and avoid repeated installation attempts for revdep checks #1300

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Aug 24, 2016

  • revdep_check() and check_cran() gain "install_dir" argument
    • default value assumed in revdep_check()
  • output for failed installations is collected there in .out
    files
  • presence of such a file omits attempts to download and install
    • via new "out_dir" and "skip_if_log_exists" arguments

Closes #1284 (=includes it).

NEWS entry:

* Installation failures are logged during revdep checking, by default in
  `revdep/install`. Once an installation has failed, it is not attempted
  a second time (#1300, @krlmlr).

@krlmlr krlmlr referenced this pull request Aug 24, 2016

Merged

Revdep check improvements #1284

Capture installation output for revdep checks
- revdep_check() and check_cran() gain "install_dir" argument
    - default value assumed in revdep_check()
- output for failed installations is collected there in <package-name>.out files
- presence of such a file omits attempts to download and install
    - via new "out_dir" and "skip_if_log_exists" arguments
@wch

This comment has been minimized.

Member

wch commented Sep 7, 2016

I'm glad you're making these improvements. One thing I ran into: when I ran revdep_check() and it failed to install the package that I'm doing the revdep checks on, it also gave the uninformative error message. In my case, it was because the R lib directory that I had chosen wasn't writable by the user. It would be helpful to have more information in case the target package fails to install.

> revdep_check()
Reverse dependency checks for shiny ===========================================
Saving check results in `revdep/checks/`
Saving install results in `revdep/install/`
Computing reverse dependencies... AFM, AdaptGauss, BBEST, BayesBD, BayesianNetwork, CLME, CTTShiny, ChannelAttributionApp, Cite, CosmoPhotoz, DT, DVHmetrics, DynNom, ECharts2Shiny, EMMAgeo, EMSaov, EffectLiteR, EmiStatR, EpiModel, EurosarcBayes, Factoshiny, FreqProf, G2Sd, HH, IMP, IRTShiny, ImportExport, IncucyteDRC, LDAvis, MAVIS, MetaAnalyser, NNTbiomarker, OpenImageR, QCAGUI, RGA, RJafroc, RLumShiny, RQuantLib, ReporteRs, RtutoR, RxODE, SDEFSR, SHELF, SOMbrero, SSDM, SciencesPo, SensMixed, ShinyItemAnalysis, Sofi, SpaDES, StereoMorph, SubVis, VRPM, VWPre, VineCopula, addinslist, adegenet, adespatial, ahp, archivist, backpipe, backtestGraphics, bde, beanz, benchmarkme, benchmarkmeData, bigQueryR, blkbox, bookdown, capm, chipPCR, citr, colourpicker, compareGroups, condvis, cosinor, covr, crawl, d3heatmap, datacheck, ddpcr, detzrcr, diffr, distcomp, diveRsity, dpcR, dropR, eAnalytics, edgebundleR, eechidna, eemR, elementR, embryogrowth, enviPick, evobiR, explor, fanplot, flexdashboard, flora, formatR, formattable, gazepath, geneSLOPE, ggExtra, ggThemeAssist, ggiraph, ggraptR, ggvis, gmDatabase, googleAnalyticsR, googleAuthR, googleVis, gridsampler, gwdegree, idem, ifaTools, igraphinshiny, interAdapt, irtDemo, koRpus, lavaan.shiny, leaflet, learnstats, lightsout, likert, listviewer, merTools, meta4diag, metricsgraphics, miniUI, mirt, mirtCAT, mldr, mlr, mlxR, mplot, mwaved, nbc4va, npregfast, pairsD3, paramGUI, phenology, pipe.design, pitchRx, plotROC, plotSEMM, plotly, polmineR, poppr, pqantimalarials, qrage, questionr, quipu, rAmCharts, radarchart, rangeMapper, rcrossref, refund.shiny, repo, rgl, rgpui, rhandsontable, rintrojs, rivr, rmarkdown, rtable, sadists, sdm, searchConsoleR, seasonal, sglr, shinyAce, shinyBS, shinyDND, shinyFiles, shinyRGL, shinyTime, shinyTree, shinybootstrap2, shinydashboard, shinyjs, shinystan, shinythemes, shinytoastr, shotGroups, signalHsmm, simPATHy, soc.ca, sparkTable, squid, statnetWeb, subspaceMOA, swirlify, synthACS, tableHTML, tabplot, tigerstats, timeline, timeseriesdb, timevis, treemap, treescape, trelliscope, webshot, weightr, wppExplorer, xxIRT
Installing shiny 0.13.2.9005 and dependencies to /R-lib/
Error: Command failed (1)

@krlmlr krlmlr referenced this pull request Oct 5, 2016

Merged

Revdep check improvements #1366

@hadley hadley closed this in #1366 Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment