New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamp to messages in 'build_win' #1367

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@achubaty

achubaty commented Oct 5, 2016

A couple reasons to add a timestamp:

  1. When submitting to win-builder, package build can sometimes take a while prior to submission and I like having an indication of how long it takes.
  2. I sometimes submit to win-builder and if don't get an email within the 30-60 minutes or I switch tasks while waiting for the email, it's nice to see exactly how long ago the package was submitted.

achubaty added some commits Oct 5, 2016

@hadley

This comment has been minimized.

Member

hadley commented Nov 3, 2016

I like this idea, but I think the timestamp needs to only appear in one place, and I'd prefer something custom created with strftime() + Sys.time(). Maybe "10:30pm (2016-10-11)".

While you're in there, it might be worth updating the time limit. I'm seeing times of more like 15-30 minutes lately.

achubaty added some commits Nov 3, 2016

update timestamp and win-builder email wait time
* removed time stamp during package build as requested
* update timestamp in win-builder upload as requested
* win-builder email wait time updated to 15-30 minutes as requested
@achubaty

This comment has been minimized.

achubaty commented Nov 3, 2016

@hadley good suggestions. I've updated as requested.

Note: there's an unrelated error in the travis checks on R-devel that's causing a failure (#1389), as well as some unrelated errors locally:

checking tests ... ERROR
Running the tests intests/test-that.Rfailed.
Last 13 lines of output:


  testthat results ================================================================
  OK: 409 SKIPPED: 0 FAILED: 6
  1. Failure: install_bioc (@test-bioconductor.r#39) 
  2. Error: install_bioc (@test-bioconductor.r#40) 
  3. Error: github info and links can be queried and manipulated (@test-github-connections.R#49) 
  4. Error: github_info() prefers, but doesn't require, remote named 'origin' (@test-github-connections.R#93) 
  5. Error: install on packages adds metadata (@test-remote-metadata.R#15) 
  6. Failure: remote_sha.github_remote returns expected value if remote does exist (@test-remotes.r#75) 

  Error: testthat unit tests failed
  Execution halted
R CMD check results
1 error  | 0 warnings | 0 notes

R CMD check succeeded

I have all the package dependencies (including Suggests) installed and up to date.

@hadley

This comment has been minimized.

Member

hadley commented Aug 1, 2017

@jimhester can you please squash-merge by hand?

@jimhester

This comment has been minimized.

Member

jimhester commented Aug 3, 2017

Thanks!

Merged by hand at 95a1ad6, so closing this PR.

@jimhester jimhester closed this Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment