Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if commas missing in remotes #1511

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@ianmcook
Copy link
Contributor

ianmcook commented May 18, 2017

If commas are missing between entries on separate lines under Remotes: in DESCRIPTION, the resulting error is:

Error in curl::curl_fetch_disk(url, x$path, handle = handle) : 
  URL using bad/illegal format or missing URL

This does not provide much help to the user.

I think omitting these commas is a common mistake. For example: #1055

With the changes in this pull request, devtools throws an informative error in this case. The code checks for a newline in any of the remotes entries after splitting them on commas followed by optional space characters (which includes newlines).

@hadley hadley requested a review from jimhester Aug 2, 2017

@jimhester jimhester self-assigned this Aug 2, 2017

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Aug 3, 2017

Thanks!

I merged this manually (668a580) so GitHub did not close this PR automatically.

@jimhester jimhester closed this Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.