Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use foghorn to report results of CRAN checks during release process #1672

Merged
merged 4 commits into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@fmichonneau
Copy link
Contributor

fmichonneau commented Dec 8, 2017

As suggested by Hadley in fmichonneau/foghorn#15, I included the details of the CRAN check results during the release process.

Instead of having: "Have you fixed all existing problems at ?", release() now shows the output of the CRAN check results directly in the terminal before asking the question. See below an example for purrrlyr. PTAL.

screenshot from 2017-12-08 15-13-08

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Feb 13, 2018

Thanks! Unfortunately foghorn has an implicit dependency on stringr, (through rvest->selectr->stringr) so we cannot directly depend on it in devtools. You will need make this code conditional, e.g. if (requireNamespace("foghorn")) { ... } in devtools::release() and put foghorn in Suggests: instead.

Also please add a note to NEWS.md with the change and mentioning the issue number and your GitHub username.

@fmichonneau

This comment has been minimized.

Copy link
Contributor Author

fmichonneau commented Feb 24, 2018

Thanks @jimhester! I updated the pull request to make the use of foghorn conditional. The travis tests fail but it looks unrelated to my changes. Let me know if the logic I use to only display the "have you fixed all existing problems at..." message when:

  • foghorn is absent OR
  • if foghorn detects that there are things to fix

seems reasonable. PTAL.

@jimhester jimhester force-pushed the fmichonneau:add-foghorn branch from 7e6f667 to 7bb5ea5 Feb 26, 2018

@jimhester jimhester merged commit 5820b51 into r-lib:master Feb 26, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Feb 26, 2018

Looks great, thanks!

@fmichonneau fmichonneau deleted the fmichonneau:add-foghorn branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.