New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward path to usethis::use_rstudio() #1823

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lionel-
Member

lionel- commented Jul 20, 2018

No description provided.

@jimhester

This comment has been minimized.

Member

jimhester commented Jul 20, 2018

Changing the working directory would only help if you had not called a usethis function to set the project yet. Once the usethis project is set the working directory is ignored. You need to use usethis::proj_set() to change the active project rather than changing the working directory.

Perhaps instead warn_unless_current_dir() should be changed to throw an error if pkg$path does not equal usethis::proj_get()

@lionel-

This comment has been minimized.

Member

lionel- commented Jul 20, 2018

Perhaps instead warn_unless_current_dir() should be changed to throw an error if pkg$path does not equal usethis::proj_get()

That would break ESS and force devtools users to change their workflow (custom scripts, etc) right away. Is a transition period possible?

Changing the working directory would only help if you had not called a usethis function to set the project yet.

Should I change setwd() with proj_set()?

@jimhester jimhester closed this in 56ee182 Jul 20, 2018

@jimhester

This comment has been minimized.

Member

jimhester commented Jul 20, 2018

Ok I have added temporarily setting the active project to warn_unless_current_dir(), so we can preserve existing behavior (with a warning) for all usethis functions in devtools.

@lionel-

This comment has been minimized.

Member

lionel- commented Jul 20, 2018

Thanks

@lionel- lionel- deleted the lionel-:fix-deprecated branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment