New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed upgrade through to install_deps #1898

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@Paxanator
Contributor

Paxanator commented Oct 23, 2018

Not sure if I need to make an issue first, but the upgrade argument isn't being passed through to install_deps.

If there's guidance on writing a test I can do that as well

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 23, 2018

Yes you are correct, sorry for the oversight and thank you for the fix!

@jimhester jimhester merged commit 7575090 into r-lib:master Oct 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Paxanator

This comment has been minimized.

Contributor

Paxanator commented Oct 23, 2018

Thanks @jimhester ! Is there a planned maintenance release in the future?

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 23, 2018

Yes, probably in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment