Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for auth_token #418

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@jeroen
Copy link
Member

jeroen commented Jan 24, 2014

Simple addition for using an access token instead of username/password to authenticate. Access tokens can be generated by any user on https://github.com/settings/applications.

Access tokens are much preferred over username/password because they prevent the user from typing/hardcoding their password anywhere (which could end up in plain-text logs, etc). And if a token gets leaked, it can easily be revoked, and the attacker cannot use the token to change the Github password and lock-out the actual user.

@imanuelcostigan

This comment has been minimized.

Copy link
Contributor

imanuelcostigan commented Jan 26, 2014

👍

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jan 26, 2014

Could you please update the docs so that R CMD check passes?

I'd also wonder if we should deprecate auth_user and password in favour of this method.

@jeroen

This comment has been minimized.

Copy link
Member Author

jeroen commented Jan 28, 2014

I think that would be preferred, if you're not worried about breaking backward compatibility.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jan 28, 2014

You can deprecate like branch is deprecated

@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Feb 10, 2014

The build seems to fail because docs are out of sync with code. Roxygenizing could help. (Perhaps Travis should run roxygenize to avoid this kind of error?) See also #397.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Mar 17, 2014

@jeroenooms could you please re-roxygenise. Deprecation with a warning would also be useful.

jeroen added some commits Mar 17, 2014

@hadley hadley closed this in 41e146c Mar 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.