New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_win now builds R-release and R-devel by default #438

Merged
merged 3 commits into from Mar 17, 2014

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Mar 17, 2014

Sample output:

Building windows version of ProjectTemplate for R-release, R-devel with win-builder.r-project.org.

...
* building 'ProjectTemplate_0.5-1.tar.gz'

Check your email for a link to the built packages in 30-60 mins.

Kirill Müller added some commits Mar 17, 2014

Kirill Müller
R/build.r Outdated
" with win-builder.r-project.org.\n")
version <- match.arg(version, several.ok = TRUE)
if (!quiet) message("Building windows version of ",

This comment has been minimized.

@hadley

hadley Mar 17, 2014

Member

Could you put this in {} please?

R/build.r Outdated
built_path <- build(pkg, tempdir(), args = args, quiet = quiet)
on.exit(unlink(built_path))
ftpUpload(built_path, paste("ftp://win-builder.r-project.org/", version,
"/", basename(built_path), sep = ""))
lapply(version,

This comment has been minimized.

@hadley

hadley Mar 17, 2014

Member

Maybe generate the url outside of lapply?

url <- paste0("ftp://win-builder.r-project.org/", version, "/", basename(built_path))
lapply(url, ftpUpload, what = built_path)
R/build.r Outdated
message("Check your email for a link to the built package in 30-60 mins.")
message("Check your email for a link to the built package",
ifelse(length(version) > 1, "s", ""),

This comment has been minimized.

@hadley

hadley Mar 17, 2014

Member

Should really be if, not ifelse, since not vectorised. And maybe this block should also be wrapped in if (!quiet) {}

Kirill Müller
@krlmlr

This comment has been minimized.

Member

krlmlr commented Mar 17, 2014

I think I've addressed all issues.

hadley added a commit that referenced this pull request Mar 17, 2014

Merge pull request #438 from krlmlr/build_win-both
build_win now builds R-release and R-devel by default

@hadley hadley merged commit cc397de into r-lib:master Mar 17, 2014

1 check passed

default The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Mar 17, 2014

Thanks!

@krlmlr krlmlr deleted the krlmlr:build_win-both branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment