New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't force dependencies = TRUE in install_github() #462

Merged
merged 2 commits into from Apr 21, 2014

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Apr 17, 2014

No description provided.

Kirill Müller added some commits Apr 16, 2014

@hadley

This comment has been minimized.

Member

hadley commented Apr 17, 2014

That wasn't a regression it was a deliberate change. The problem is that there's two uses of install github:

  1. For user. Needs vignettes to be built so needs suggested packages.
  2. For developer or as prereq. Doesn't need vignettes. But probably want suggested packages so that you can run all tests.

I'm not sure how to better differentiate these use cases.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Apr 17, 2014

I'm fine with saying dep=NA if I don't need the suggested packages. The problem is that now the dependencies parameter is ignored -- install_github_single is called with dependencies = TRUE, and this PR fixes it.

hadley added a commit that referenced this pull request Apr 21, 2014

Merge pull request #462 from krlmlr/install-github-dependencies
don't force dependencies = TRUE in install_github()

@hadley hadley merged commit b6c3f62 into r-lib:master Apr 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Apr 21, 2014

Oh got it!

@krlmlr krlmlr deleted the krlmlr:install-github-dependencies branch Apr 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment