Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_coveralls function #681

Merged
merged 9 commits into from Apr 28, 2015

Conversation

Projects
None yet
2 participants
@jimhester
Copy link
Member

jimhester commented Jan 6, 2015

This implements the use_coveralls function to add a coveralls test
coverage report to the repository. It also enables a coveralls report
for the devtools repository.

closes #680

I did not include the roxygen results other than NAMESPACE in this pull request to make the diff easier to read.

Let me know if you want anything changed, or if my description is not clear.

You can see examples of repositories with coveralls enabled at

@jimhester

This comment has been minimized.

Copy link
Member Author

jimhester commented Jan 7, 2015

Sorry, had a few issues with the original pull request, dfdae79 should be good to go though, you will also need to enable the repo at https://coveralls.io/repos/new.

jimhester added some commits Jan 6, 2015

use_coveralls function
This implements the use_coveralls function to add a coveralls test
coverage report to the repository.  It also enables a coveralls report
for the devtools repository.

closes #680

@jimhester jimhester force-pushed the jimhester:coveralls branch from ea17c5b to 0a5bfbe Jan 16, 2015

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Apr 21, 2015

Do you have plans to submit covr to CRAN? Ideally, I'd like to rely only on CRAN packages in the released version

@jimhester

This comment has been minimized.

Copy link
Member Author

jimhester commented Apr 21, 2015

I am but I am using some devtools functions which are unexported in the current release. (r-lib/covr#63). So ideally I would like to submit covr to CRAN after the next devtools release. Circular dependencies, so we would have to coordinate the releases somehow.

Alternatively I am currently working on extracting the with_* functions, R, RCMD functions from devtools into a new robustr package, along with a couple of utility functions I needed to write for covr. robustr would provide safe alternatives for modifying global state and calling R from within R. Once that is done I can convert covr and devtools to use that package for those functions and that would solve this issue.

If you have other suggestions on functions that you think would be useful to include in robustr I would be happy to include them.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Apr 21, 2015

Ok, that sounds good. In that case, I'm happy to merge this (after some review).

"(https://coveralls.io/r/", gh$username, "/", gh$repo, "?branch=master)"
)

install_loc <- grep("^install:$", travis_content)

This comment has been minimized.

Copy link
@hadley

hadley Apr 21, 2015

Member

I'm a bit leery about automatically modifying the travis file, especially now that there are two main formats. Could you please just print out instructions? (and update them for the language: r style)

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Apr 28, 2015

Bump

jimhester added some commits Apr 28, 2015

Merge remote-tracking branch 'upstream/master' into coveralls
Conflicts:
	.travis.yml
	NAMESPACE
	README.md
	man/infrastructure.Rd
	man/use_build_ignore.Rd
	man/use_data.Rd
	man/use_data_raw.Rd
	man/use_git_hook.Rd
	man/use_package.Rd
	man/use_readme_rmd.Rd
@jimhester

This comment has been minimized.

Copy link
Member Author

jimhester commented Apr 28, 2015

Ok I think everything should be ok with this now, I added a note to the NEWS as well.

@hadley hadley merged commit 5d6a62e into r-lib:master Apr 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Apr 28, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.