New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default cache argument for lint #708

Merged
merged 7 commits into from Apr 21, 2015

Conversation

Projects
None yet
2 participants
@jimhester
Member

jimhester commented Jan 27, 2015

Combined with the bugfix in 2fbfee237c39c47cda15e93e96ef74a16b4bc40d this allows use of the caching functionality in lintr.

Reference timings (lints were previously cached)

system.time(devtools::lint('../../../devtools', cache = FALSE))
#> Linting devtools.....................................................................................................................................
#>    user  system elapsed
#>  85.842   0.660  86.692

system.time(devtools::lint('../../../devtools', cache = TRUE))
#> Linting devtools.....................................................................................................................................
#>    user  system elapsed
#>   3.990   0.139   4.187
@hadley

This comment has been minimized.

Member

hadley commented Jan 30, 2015

Does this need a bump in the version req for lintr?

@jimhester

This comment has been minimized.

Member

jimhester commented Jan 30, 2015

That is a good point, I will update this

@jimhester

This comment has been minimized.

Member

jimhester commented Jan 30, 2015

Ok lintr version bumped and requirement added to devtools.

@hadley

This comment has been minimized.

Member

hadley commented Jan 30, 2015

And would you mind adding a bit more info about the cache? i.e. where it's saved and how to get rid of it. Does the cache file needed to be added to .gitignore and/or .Rbuildignore?

@jimhester

This comment has been minimized.

Member

jimhester commented Apr 9, 2015

Ok this should be ok to merge now, let me know if the documentation is unclear.

hadley added a commit that referenced this pull request Apr 21, 2015

Merge pull request #708 from jimhester/lintr
Add default cache argument for lint

@hadley hadley merged commit 7a2982f into r-lib:master Apr 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Apr 21, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment