Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dots #747

Merged
merged 2 commits into from Apr 21, 2015

Conversation

Projects
None yet
2 participants
@jimhester
Copy link
Member

jimhester commented Mar 24, 2015

Pass ellipsis to testthat::test_dir to allow filtering options

As enabled by r-lib/testthat#188

This allows you to use any of the options for grepl() from devtools::test(), perl = TRUE, inverse = TRUE, ect.

@jimhester

This comment has been minimized.

Copy link
Member Author

jimhester commented Mar 24, 2015

invert = TRUE is not an option for grepl() (which I forgot), so to get that functionality you would also need r-lib/testthat#239 in addition to this pull request.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Apr 21, 2015

Could you please add a note to NEWS?

@jimhester jimhester force-pushed the jimhester:test_dots branch from b932a76 to 91d1eb1 Apr 21, 2015

@jimhester

This comment has been minimized.

Copy link
Member Author

jimhester commented Apr 21, 2015

I have added a note to NEWS, however the build seems to have stalled. It should be ok to merge, all I did was rebase on the latest master.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Apr 21, 2015

Looks good - thanks!

hadley added a commit that referenced this pull request Apr 21, 2015

@hadley hadley merged commit 0a8c8e7 into r-lib:master Apr 21, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.