New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with_makevars instead of with_env for with_debug #788

Merged
merged 1 commit into from Jun 19, 2015

Conversation

Projects
None yet
3 participants
@jimhester
Member

jimhester commented May 5, 2015

Previously with_debug would not actually change the compilation flags
because the variables were set in the environment rather than in a
Makevars file. This change adds a with_makevars function which sets
the compilation flags in a temporary Makevars file.

A simple test to see if the previous and new behavior is to look at the compilation flags used when installing devtools.

# in devtools directory
clean_dll()
with_debug(install())

In the current master the compilation flags will be the defaults, including -O3.

Using this pull the flags will be correctly set to the debug flags.

Use with_makevars instead of with_env for with_debug
Previously with_debug would not actually change the compilation flags
because the variables were set in the environment rather than in a
Makevars file.  This change adds a `with_makevars` function which sets
the compilation flags in a temporary Makevars file.
@coveralls

This comment has been minimized.

coveralls commented May 5, 2015

Coverage Status

Coverage decreased (-0.31%) to 33.4% when pulling 9d587b3 on jimhester:with_makevars into c5c14ba on hadley:master.

hadley added a commit that referenced this pull request Jun 19, 2015

Merge pull request #788 from jimhester/with_makevars
Use with_makevars instead of with_env for with_debug

@hadley hadley merged commit c2ad072 into r-lib:master Jun 19, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.31%) to 33.4%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jun 19, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment