New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `use_coverage()` function #822

Merged
merged 1 commit into from May 29, 2015

Conversation

Projects
None yet
3 participants
@jimhester
Member

jimhester commented May 28, 2015

To add codecov.io or coveralls.io to a project, also deprecate
use_coveralls().

Closes #818

@hadley

This comment has been minimized.

Member

hadley commented May 29, 2015

Looks good, but can you merge/rebase please?

Add `use_coverage()` function
To add codecov.io or coveralls.io to a project, also deprecate
`use_coveralls()`.

Closes #818
@jimhester

This comment has been minimized.

Member

jimhester commented May 29, 2015

Rebased to 2cca68d

hadley added a commit that referenced this pull request May 29, 2015

@hadley hadley merged commit 7d12dd8 into r-lib:master May 29, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.21%) to 33.31%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented May 29, 2015

Thanks!

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jun 2, 2015

I think the warnings in R CMD check relate to this pull request:

Undocumented arguments in documentation object 'use_coveralls'
  ‘pkg’

Undocumented arguments in documentation object 'infrastructure'
  ‘type’

They disappear if I revert 0840e0b.

jimhester added a commit to jimhester/devtools that referenced this pull request Jun 2, 2015

Properly document all arguments
- use_coveralls
- use_coverage

Fixes issue pointed out by @krlmlr at r-lib#822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment