New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rtools registry path detection #844

Merged
merged 1 commit into from Jun 19, 2015

Conversation

Projects
None yet
3 participants
@Kevin-Jin
Contributor

Kevin-Jin commented Jun 10, 2015

First search for the key in HKCU before attempting HKLM in case the user installed Rtools while on a non-admin account.

Improve rtools registry path detection
First search for the key in HKCU before attempting HKLM in case the user installed Rtools while on a non-admin account.
@hadley

This comment has been minimized.

Member

hadley commented Jun 10, 2015

@jjallaire

This comment has been minimized.

Collaborator

jjallaire commented Jun 11, 2015

Thanks! I just made the same change: rstudio/rstudio@be6ba09

One difference is that I scan HKLM first so that the detected version won't change from under existing users (i.e. we'll always do exactly what we did before and then only if we fail entirely will we scan HKCU).

hadley added a commit that referenced this pull request Jun 19, 2015

Merge pull request #844 from Kevin-Jin/patch-1
Improve rtools registry path detection

@hadley hadley merged commit 01fbaaa into r-lib:master Jun 19, 2015

2 of 3 checks passed

codecov/patch 0.00% (min required 90%)
Details
codecov/commit 36.55% (min required 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment