Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_s4_classes() respecting inheritance #849

Merged
merged 8 commits into from Sep 3, 2015
Merged

remove_s4_classes() respecting inheritance #849

merged 8 commits into from Sep 3, 2015

Commits on Jun 11, 2015

  1. remove_s4_classes() in reverse order 

    prevents derived classes to remain orphan
Fixes r-lib#848
    Facundo Muñoz committed Jun 11, 2015
    Copy the full SHA
    9fceb43 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2015

  1. sort s4 classes so that extended classes are first 

    Fixes r-lib#848 (now it does)
    Facundo Muñoz committed Jun 12, 2015
    Copy the full SHA
    2cbe0a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2015

  1. topological sorting of s4 classes

    Facundo Muñoz committed Jun 15, 2015
    Copy the full SHA
    caf388a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2015

  1. corrected sorting algorithm

    Facundo Muñoz committed Jun 22, 2015
    Copy the full SHA
    43e2ed4 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2015

  1. unit test for topological sorting of s4 classes 

    solved previous unanswered question in a related test (s4-unload)
    Facundo Muñoz committed Jul 13, 2015
    Copy the full SHA
    cbd8122 View commit details
    Browse the repository at this point in the history

  2. isolate test with auxiliar package

    Facundo Muñoz committed Jul 13, 2015
    Copy the full SHA
    f1bd570 View commit details
    Browse the repository at this point in the history

  3. Consider corner cases with 0 or 1 classes

    Facundo Muñoz committed Jul 13, 2015
    Copy the full SHA
    ff27287 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2015

  1. Style guidelines, licence and news item

    Facundo Muñoz committed Sep 3, 2015
    Copy the full SHA
    608e5aa View commit details
    Browse the repository at this point in the history