New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert errors to warnings when processing NAMESPACE #921

Merged
merged 3 commits into from Sep 10, 2015

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Sep 10, 2015

in process_imports

Reason: Otherwise, devtools::document cannot fix a NAMESPACE file that became invalid due to changes in external packages

(I'm not sure if this worked before.)

Kirill Müller added some commits Sep 10, 2015

Kirill Müller
convert errors to warnings when processing NAMESPACE
in `process_imports`

Reason: Otherwise, `devtools::document` cannot fix a `NAMESPACE` file that became invalid due to changes in external packages
Kirill Müller

hadley added a commit that referenced this pull request Sep 10, 2015

Merge pull request #921 from krlmlr/namespace-warning
convert errors to warnings when processing NAMESPACE

@hadley hadley merged commit 4356125 into r-lib:master Sep 10, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Sep 10, 2015

Thanks!

@krlmlr krlmlr deleted the krlmlr:namespace-warning branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment