New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove with_ functions from devtools and use those from withr #925

Merged
merged 10 commits into from Oct 27, 2015

Conversation

Projects
None yet
3 participants
@jimhester
Member

jimhester commented Sep 13, 2015

I am planning on submitting withr to CRAN in the next week or so. But I wanted to send a PR to iron out any bugs (and try the new Remotes: feature)

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 26, 2015

This now works, all of the calls to with_ functions within devtools are replaced by calls to the corresponding withr functions.

However we need to decide how to handle calls to the old with_ function from other packages. There are three possibilities I see

  1. Do nothing (this will break packages that use the functions, but will force them to update to withr functions immediately).
  2. Continue to supply the functions and with a .Deprecated warning, remove them at a later date.
  3. Export the existing functions as aliases to the corresponding withr functions.

1 isn't going to happen so 2 seems to be the best option, as part of the reason for splitting the functions out was so fewer packages would need to depend on devtools directly.

@hadley

This comment has been minimized.

Member

hadley commented Oct 26, 2015

I think 1 would be ok if you did the revdep checks and informed the revdep maintainers

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 26, 2015

Oh well... already did the deprecation work!

bee53b7 should be good (assuming it passes).

hadley added a commit that referenced this pull request Oct 27, 2015

Merge pull request #925 from jimhester/withr
Remove with_ functions from devtools and use those from withr

@hadley hadley merged commit be08bbf into r-lib:master Oct 27, 2015

1 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Oct 27, 2015

Thanks!

@krlmlr

This comment has been minimized.

krlmlr commented on R/check-cran.r in 324e83b Nov 16, 2015

@jimhester: There's no set_libpaths() in withr.

This comment has been minimized.

Owner

jimhester replied Nov 16, 2015

Yes I know, this was fixed with r-lib#978 last week.

This comment has been minimized.

krlmlr replied Nov 16, 2015

My bad, I thought I had the latest changes merged in. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment