New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degrade gracefully if summary cannot be retrieved for one of the checked packages #929

Merged
merged 4 commits into from Jan 20, 2016

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Sep 16, 2015

  • example: if the DESCRIPTION file in one of the checked packages is missing
@@ -63,6 +65,14 @@ revdep_check_summary <- function(res) {
)
}
try_check_summary_package <- function(path) {
res <- try(check_summary_package(path), silent = TRUE)

This comment has been minimized.

@hadley

hadley Jan 12, 2016

Member

Can you please use tryCatch() instead? I don't like the way try() works

Kirill Müller added some commits Sep 16, 2015

Kirill Müller
Degrade gracefully if summary cannot be retrieved for one of the chec…
…ked packages

- example: if the DESCRIPTION file in one of the checked packages is missing
Kirill Müller
Kirill Müller

@hadley hadley merged commit 50c5993 into r-lib:master Jan 20, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jan 20, 2016

Thanks!

@krlmlr krlmlr deleted the krlmlr:revdep-no-description branch Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment