New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdep_check verifies integrity of already downloaded package files #930

Merged
merged 3 commits into from Jan 21, 2016

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Sep 16, 2015

to avoid surprises

@hadley

This comment has been minimized.

Member

hadley commented Jan 12, 2016

Can you please merge/rebase?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 13, 2016

Rebased.

}
is_source_pkg <- function(path, subdir = NULL) {
res <- try(source_pkg_info(path = path, subdir = subdir), silent = TRUE)

This comment has been minimized.

@hadley

hadley Jan 13, 2016

Member

Could you eliminate use of try() here please?

This comment has been minimized.

@hadley

hadley Jan 20, 2016

Member

Think you missed this comment

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 21, 2016

Rebased, now using tryCatch() instead of try().

tryCatch({
source_pkg_info(path = path, subdir = subdir)
TRUE
}, error = function(e) return(FALSE))

This comment has been minimized.

@hadley

hadley Jan 21, 2016

Member

Don't need explicit return here, but it's not a blocker.

hadley added a commit that referenced this pull request Jan 21, 2016

Merge pull request #930 from krlmlr/revdep-check-corrupted-tar-gz
revdep_check verifies integrity of already downloaded package files

@hadley hadley merged commit 49eb273 into r-lib:master Jan 21, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jan 21, 2016

Thanks!

@krlmlr krlmlr deleted the krlmlr:revdep-check-corrupted-tar-gz branch Jan 21, 2016

@krlmlr krlmlr restored the krlmlr:revdep-check-corrupted-tar-gz branch Feb 4, 2016

@krlmlr krlmlr deleted the krlmlr:revdep-check-corrupted-tar-gz branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment