Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to functions reexported from other packages #134

Closed
krlmlr opened this issue Mar 23, 2022 · 1 comment · Fixed by #144
Closed

Links to functions reexported from other packages #134

krlmlr opened this issue Mar 23, 2022 · 1 comment · Fixed by #144
Labels
feature a feature request or enhancement
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 23, 2022

Should point to the original function?

# Observed
downlit::href_topic("install_github", "devtools")
#> [1] "https://devtools.r-lib.org/reference/remote-reexports.html"

# Desired?
downlit::href_topic("install_github", "remotes")
#> [1] "https://remotes.r-lib.org/reference/install_github.html"

# Perhaps with referrer?
downlit::href_topic("install_github", "remotes")
#> [1] "https://remotes.r-lib.org/reference/install_github.html?ref=https://devtools.r-lib.org/reference/remote-reexports.html"

Created on 2022-03-23 by the reprex package (v2.0.1)

@hadley
Copy link
Member

hadley commented Jun 10, 2022

downlit already handles reexports, but only use that code path if the topic name is reexports.Rd. I just need to make it a bit more general.

@hadley hadley added the feature a feature request or enhancement label Jun 17, 2022
@hadley hadley added this to the 0.4.1 milestone Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants