Use conditionMessage() to render conditions
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hadley If you agree with these changes, I wonder if it might be possible to get this into v0.3.0? (Sorry, I wouldn't normally ping you, but I saw you're in the early stages of a release process.) |
|
Sure, could you add a news bullet too please? |
|
@hadley - I put the NEWS item immediately after the item about other changes to messages, warnings and errors. Please let me know if you'd prefer it to go at the end? |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following the error constructor design pattern, we might have condition objects with an empty
messagefield. Instead, their message is constructed via theconditionMessage()S3 method. Currently, such condition messages are omitted from the {downlit} output.