file_exists() does not perform path expansion (anymore)

[lorenzwalthert]

on macOS. Maybe related to #295? This is likely to break the reverse dependency test.

> fs::file_exists(fs::path_expand('~'))
/Users/lorenz 
         TRUE 
> fs::file_exists('~')
    ~ 
FALSE 
> packageVersion('fs')
[1] ‘1.5.0.9000’

Previously, this worked:

> fs::file_exists(fs::path_expand('~'))
/Users/lorenz 
         TRUE 
> fs::file_exists('~')
    ~ 
TRUE 
> packageVersion('fs')
[1] ‘1.5.’

Related: #222

[lorenzwalthert]

This breaks {precommit} for a subset of users (part of {precommit} that's not tested on CRAN) now that {fs} is updated on CRAN and I forgot about it and found the half a year old issue. This potentially breaks other peoples code. Will the old behavior restored?

[gaborcsardi]

Yes, it seems that now we need to call path_expand() in file_exists(). If this breaks lots of code, then we can have a patch release soon.

[lorenzwalthert]

I mean it (apparently) did not break CRAN packages but I imagine people also have this in in their analysis code. I'd appreciate a patch release but I'll anyways release a new {precommit} version in the next 7 days.

[gaborcsardi]

It seems to me that most file_* functions call path_expand(), so file_exists() should do the same.

[salim-b]

I mean it (apparently) did not break CRAN packages (...)

It actually did break the pins pkg when used with local folder boards created with e.g. pins::board_folder(path = "~/my_board") because of this line. Just cost me over an hour to figure that out. 😬

[gaborcsardi]

I will make a new release in ~ 2 days.

[jennybc]

It turns out this is being felt via usethis as well.