Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default scope on GCE #110

Merged
merged 4 commits into from Oct 2, 2019

Conversation

@MarkEdmondson1234
Copy link
Contributor

MarkEdmondson1234 commented Sep 5, 2019

A tiny quality of life improvement proposal, since this function is only called when on GCE, add the default to that scope as otherwise I scratched my head a bit wondering why it wasn't working.

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Oct 2, 2019

@craigcitro Is there any reason NOT to merge this?

I defer to you and @MarkEdmondson1234 because I've got no personal experience with this particular credential flow at this point.

@jennybc jennybc requested a review from craigcitro Oct 2, 2019
Copy link
Collaborator

craigcitro left a comment

I'm on the fence, but I suspect this is a worthwhile quality of life improvement.

It's possible to create a GCE VM whose service account has a different/restricted set of scopes, eg cloud-platform wouldn't be included.

That said, it's a rare situation, and a user who was customizing their VMs in that way would likely understand what went wrong, so my feeling is that it's worth making the common case easier.

@jennybc jennybc changed the title add default scope Add default scope on GCE Oct 2, 2019
@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Oct 2, 2019

Thanks!

@jennybc jennybc merged commit 3c19604 into r-lib:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.