Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for oauth info in web key in client_secret.json #155

Merged
merged 3 commits into from Oct 31, 2020

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Oct 30, 2020

Closes #94

To repro, create a new OAuth client ID, and for "Application type", choose "web". If you download the secrets JSON file for this, you'll see that the key is called "web" instead of "installed".

R/oauth-app.R Outdated Show resolved Hide resolved
@jennybc
Copy link
Member

jennybc commented Oct 31, 2020

Do you have the ability to merge? If not, do you want that, for now and future?

@jennybc
Copy link
Member

jennybc commented Oct 31, 2020

Ah, I think you must, because this is coming from an internal branch.

Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
@jcheng5 jcheng5 merged commit 8db62ab into master Oct 31, 2020
@jennybc jennybc deleted the client_secret_web branch October 21, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oauth_app_from_json() does not read web based client JSON
2 participants