Make it easier to remove a cred fun from registry - #224
Merged
Conversation
Lots of other general upgrades
jennybc
changed the title
jennybc
marked this pull request as ready for review
November 22, 2022 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus lots of other general upgrades
Relates to #187, relates to r-lib/gmailr#174
This is one move towards making it easier to control what
token_fetch()does. This PR makes it relatively easy to remove a specific credential fetcher, such ascredentials_gce(). I plan to take more steps in one or more separate PRs to maketoken_fetch()more likely to pick the right credential fetcher without having to actually touch the registry.