Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return NULL for empty responses #66

Closed
hadley opened this issue Nov 14, 2017 · 3 comments
Closed

Return NULL for empty responses #66

hadley opened this issue Nov 14, 2017 · 3 comments
Milestone

Comments

@hadley
Copy link
Member

hadley commented Nov 14, 2017

When called on repo with no labels, gh("GET /repos/:owner/:repo/labels") returns ""

@hadley hadley changed the title Bad failure mode Make gh type-stable Nov 29, 2018
@hadley
Copy link
Member Author

hadley commented Nov 29, 2018

It should always return a list

@gaborcsardi
Copy link
Member

I am afraid that this requires going over all API endpoints, which I would avoid if possible.

@hadley
Copy link
Member Author

hadley commented Nov 29, 2018

Well maybe it should return NULL then; it certainly shouldn't be "".

@hadley hadley changed the title Make gh type-stable Return NULL for empty responses Jan 7, 2020
@gaborcsardi gaborcsardi added this to the 1.1.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants