Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when .progress = FALSE in gh() #115

merged 2 commits into from Jun 6, 2020


Copy link

This is a very simple fix for #114 to avoid calling update_progress_bar() when .progress = FALSE.

Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #115 into master will decrease coverage by 6.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
- Coverage   51.54%   45.37%   -6.17%     
  Files          12       12              
  Lines         454      454              
- Hits          234      206      -28     
- Misses        220      248      +28     
Impacted Files Coverage Δ
R/package.R 58.82% <0.00%> (-8.83%) ⬇️
R/gh_whoami.R 41.17% <0.00%> (-58.83%) ⬇️
R/gh_response.R 42.37% <0.00%> (-25.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfff447...e36daa0. Read the comment docs.

Copy link

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much! Could you please add a bullet point to, thanking yourself? :)

gadenbuie added a commit to gadenbuie/gh that referenced this pull request Jun 6, 2020
@gadenbuie gadenbuie force-pushed the fix-114-disabled-progress-bar branch from 3495bdf to e36daa0 Compare June 6, 2020 20:07
Copy link
Contributor Author

No problem! (Sorry for the force-push, I caught a typo as soon as I pressed "Enter" 😜)

@gaborcsardi gaborcsardi merged commit faf4206 into r-lib:master Jun 6, 2020
2 checks passed
Copy link

Great, thanks much!

@gadenbuie gadenbuie deleted the fix-114-disabled-progress-bar branch June 7, 2020 01:31
@gaborcsardi gaborcsardi mentioned this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants