Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination improvements #176

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Pagination improvements #176

merged 4 commits into from
Oct 31, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Feb 16, 2023

  • Use a real progress bar
  • Add more tests
  • Allow either .per_page or per_page (this has messed me up so many times)

gaborcsardi
gaborcsardi approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to skip the tests if there is no token or we are on cran?

R/gh.R Show resolved Hide resolved
@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 8617b13 into main Oct 31, 2023
11 of 12 checks passed
@gaborcsardi gaborcsardi deleted the pagination branch October 31, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @gaborcsardi