New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 warning on `content` call from print.response() #327

Closed
sckott opened this Issue Jan 29, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@sckott

sckott commented Jan 29, 2016

with httr v1.1.0 I now get No encoding supplied: defaulting to UTF-8. warning when a response class prints

#> Response [http://api.crossref.org/journals/0413-6597]
#>   Date: 2016-01-29 00:25
#>   Status: 404
#>   Content-Type: text/plain
#>   Size: 19 B
#> No encoding supplied: defaulting to UTF-8.

yet the user can't set encoding for the internal use of content() in print.response() here https://github.com/hadley/httr/blob/f7593b7d5b3f9396469d1220dd4b38206fbb7d2e/R/response.r#L57 - should this have content(x, "text", encoding = "UTF-8") instead? Or am i missing something

@jread-usgs

This comment has been minimized.

jread-usgs commented Feb 1, 2016

👍

1 similar comment
@pan0ramic

This comment has been minimized.

pan0ramic commented Feb 23, 2016

+1

@hadley hadley closed this in 25557c0 May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment