Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.httr-oauth file should be created with perms 0600 by default #365

Closed
craigcitro opened this issue May 12, 2016 · 3 comments
Closed

.httr-oauth file should be created with perms 0600 by default #365

craigcitro opened this issue May 12, 2016 · 3 comments

Comments

@craigcitro
Copy link
Contributor

@craigcitro craigcitro commented May 12, 2016

Title says it all -- I can't see a reason that we shouldn't default to creating the file with restrictive permissions. I'm happy to send a PR if folks agree.

@hadley
Copy link
Member

@hadley hadley commented May 20, 2016

PR would be awesome :)

@jennybc
Copy link
Member

@jennybc jennybc commented May 20, 2016

Could this make it hard to read .httr-oauth in some Shiny situations?

hadley added a commit that referenced this issue May 24, 2016
Fixes #365
@hadley hadley closed this in #371 May 24, 2016
@daattali
Copy link
Contributor

@daattali daattali commented Jun 9, 2016

I agree, I also think this is going to introduce bugs to shiny users.

For example, shiny apps on a shiny server by default run as the "shiny" user, who is normally not the owner of the file, so shiny apps will get permission denied issues. Is this correct, or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants