New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'terminate_on' parameter of RETRY() more intuitive #522

Closed
mvkorpel opened this Issue May 16, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@mvkorpel

mvkorpel commented May 16, 2018

Using the terminate_on parameter of RETRY() seems a bit unwieldy, or it could be more intuitive. Let's say I would like to stop retrying on code 403 ("Forbidden"). In my opinion, the intuitive way to do this is to specify terminate_on = 403. However, this does not have the desired effect, as even code 200 ("OK") will then cause retries. To do the right thing, one must use terminate_on = c(200, 403), or possibly something like terminate_on = c(100:399, 403) to account for all imaginable non-error codes.

The parameter works exactly as documented, but I think it would be great to have a user-friendly way to (by default?) include non-error codes (< 400) on top of the set given in terminate_on. Alternatively, a puzzled user might appreciate a note in the ?RETRY document about the non-error codes.

I originally wrote this down as a comment to pull request #459.

hadley added a commit that referenced this issue Nov 23, 2018

@hadley hadley closed this in 9c36d69 Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment