Fix url_ok bug, status codes are integers #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
added a commit
that referenced
this pull request
Aug 22, 2014
Fix url_ok bug, status codes are integers
|
Thanks! |
|
Would you mind also adding a note to NEWS? |
|
Sure, I can try. I just don't know when it broke, if it broke since the last release, then probably no NEWS entry is needed. Anyway, I'll take a look. |
|
It happened here: b0ab387 |
|
NEWS: #134 |
hadley
added a commit
that referenced
this pull request
Aug 22, 2014
Add news entry for url_ok() fix (#133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens:
Because status codes are converted to integers here:
https://github.com/hadley/httr/blob/26d986de55c2142e91921a1fd94ad01311e6ebf0/R/perform.R#L66
But the test is against a real number:
https://github.com/hadley/httr/blob/26d986de55c2142e91921a1fd94ad01311e6ebf0/R/response-status.r#L155
Also added some simple tests for this.