New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Content-type" -> "Content-Type" #142

Merged
merged 1 commit into from Sep 6, 2014

Conversation

Projects
None yet
2 participants
@hmalmedal
Contributor

hmalmedal commented Sep 6, 2014

RFC 7231 says "Content-Type".

I came across a server that gave response code 500 when presented with "Content-type".

"Content-type" -> "Content-Type"
RFC 7231 says "Content-Type".
@hadley

This comment has been minimized.

Member

hadley commented Sep 6, 2014

That is in violation of the HTTP spec which says headers are case-insensitve :/

hadley added a commit that referenced this pull request Sep 6, 2014

Merge pull request #142 from hmalmedal/patch-1
"Content-type" -> "Content-Type"

@hadley hadley merged commit 7891096 into r-lib:master Sep 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

jimhester added a commit to jimhester/httr that referenced this pull request Sep 8, 2014

Standardize Content-Type capitalization
While apparently the header fields are supposed to be case insensitive,
 r-lib#142 shows at least some systems do not follow the spec properly.  So
we might as well standardize all uses of `Content-Type` in the same
way.

jimhester added a commit to jimhester/httr that referenced this pull request Sep 9, 2014

Standardize Content-Type capitalization
While apparently the header fields are supposed to be case insensitive,
 r-lib#142 shows at least some systems do not follow the spec properly.  So
we might as well standardize all uses of `Content-Type` in the same
way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment