New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_url collapse path #280

Merged
merged 4 commits into from Dec 17, 2015

Conversation

Projects
None yet
2 participants
@artemklevtsov
Contributor

artemklevtsov commented Oct 2, 2015

Collapse path argument if it length more than 1.

R/url.r Outdated
if (length(url$path) > 1) {
url$path <- paste(url$path, collapse = "/")
}
path <- url$path

This comment has been minimized.

@hadley

hadley Oct 2, 2015

Member

I think you should just skip the if - there's no harm to pasting if length is 1. Then you can combine with the next line.

This comment has been minimized.

@artemklevtsov

artemklevtsov Oct 2, 2015

Contributor

Ok, done.

@hadley

This comment has been minimized.

Member

hadley commented Oct 6, 2015

And can you please add a bullet point to NEWS?

hadley added a commit that referenced this pull request Dec 17, 2015

@hadley hadley merged commit 98c4f85 into r-lib:master Dec 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Dec 17, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment