Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_url collapse path #280

Merged
merged 4 commits into from Dec 17, 2015
Merged

build_url collapse path #280

merged 4 commits into from Dec 17, 2015

Conversation

artemklevtsov
Copy link
Contributor

Collapse path argument if it length more than 1.

if (length(url$path) > 1) {
url$path <- paste(url$path, collapse = "/")
}

path <- url$path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should just skip the if - there's no harm to pasting if length is 1. Then you can combine with the next line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@hadley
Copy link
Member

hadley commented Oct 6, 2015

And can you please add a bullet point to NEWS?

hadley added a commit that referenced this pull request Dec 17, 2015
@hadley hadley merged commit 98c4f85 into r-lib:master Dec 17, 2015
@hadley
Copy link
Member

hadley commented Dec 17, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants