New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the stringr dependency #285

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
3 participants
@jimhester
Member

jimhester commented Oct 26, 2015

Stringr is a very heavy dependency (due to the stringi dependency) which means any package which uses httr has to compile this heavy dependency. This makes packages (such as devtools) take a large amount of time to build (such as on Travis). While I generally feel one should not fear heavy dependencies for most packages, because httr is a widely used foundation package having such a large dependency is not ideal.

This pull request removes this dependency by providing drop in R only replacements for the equivalent stringr functions written using base functions.

They don't provide the full functionality of the stringr functions, but they provide what is needed by the usage in httr.

All the tests and examples pass on my machine.

hadley added a commit that referenced this pull request Oct 26, 2015

Merge pull request #285 from jimhester/remove_stringr
Remove the stringr dependency

@hadley hadley merged commit c87a519 into r-lib:master Oct 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Oct 26, 2015

Thanks - I agree it's good to minimise dependencies in these infrastructure packages.

(Ooops, forgot to also ask for a bullet point in NEWS)

@jimhester

This comment has been minimized.

Member

jimhester commented Oct 26, 2015

I'll open a new PR with the NEWS change

@jeroen

This comment has been minimized.

Member

jeroen commented Oct 26, 2015

👍 for lite packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment