Has re-added code for using value of "retry-after" header as waiting time if status_code = 429 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time if status_code = 429. Now also respects value of pause_min.
hadley
reviewed
Aug 4, 2017
R/retry.R
Outdated
| @@ -91,6 +91,10 @@ backoff_full_jitter <- function(i, resp, pause_base = 1, pause_cap = 60, | |||
| error_description <- "" | |||
| status <- status_code(resp) | |||
| } | |||
| if (status == 429) { | |||
| length_429 <- as.numeric(resp$headers[["retry-after"]]) | |||
| if (!is.null(length_429) && length_429 >= pause_min) length <- length_429 | |||
There was a problem hiding this comment.
I don't think the logic is quite right here - length_429 will never be NULL because you coerce it to numeric
Inside the if statement, I'd prefer something like length <- max(pause_min, length_429)
hadley
approved these changes
Aug 4, 2017
R/retry.R
Outdated
| length_429 <- as.numeric(resp$headers[["retry-after"]]) | ||
| if (!is.null(length_429) && length_429 >= pause_min) length <- length_429 | ||
| retry_after <- resp$headers[["retry-after"]] | ||
| if (!is.null(retry_after)) length <- max(pause_min, as.numeric(retry_after)) |
There was a problem hiding this comment.
Can you please put the condition code inside of {} (indented like the rest of the code)
There was a problem hiding this comment.
Was this what you meant?
|
Perfect, thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reset my fork to the current master and re-added the code changes as discussed on #434.
The code now also respects the value of pause_min.