Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize scopes in the hash; fixes #494 #495

Merged
merged 2 commits into from Nov 22, 2018

Conversation

@jennybc
Copy link
Member

commented Nov 5, 2017

As I say in #494, it's not clear this is worth fiddling with now, but here's what I mean.

@hadley

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@jennybc jennybc force-pushed the jennybc:normalize-scopes branch from 2c343d4 to bf8cf5a Nov 22, 2018

@jennybc

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

Rebased and NEWS bullet added.

@hadley hadley merged commit 2815665 into r-lib:master Nov 22, 2018

3 checks passed

codecov/patch 100% of diff hit (target 44.66%)
Details
codecov/project 44.8% (+0.14%) compared to 5345aaf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Thanks!

@jennybc jennybc deleted the jennybc:normalize-scopes branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.