New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to pass down url query parameters to initial oauth2.0 authorization page #503

Merged
merged 31 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@cosmomeese
Contributor

cosmomeese commented Jan 23, 2018

added ability pass down url query parameters to the initial oauth2.0 authorization page. e.g. this is useful for the Fitbit API which defines additional URI parameters (such as token expiration duration, ability to force authorization page/consent and others - see Authorization Page @ https://dev.fitbit.com/build/reference/web-api/oauth2/) that must be appended to the initial authorization URL.

@cosmomeese

This comment was marked as outdated.

Contributor

cosmomeese commented Apr 20, 2018

bump?
What do I do next? This is my first time attempting to contribute to an open source project on github...

@jennybc

This comment was marked as outdated.

Member

jennybc commented Apr 20, 2018

Development comes in waves. The "Contribute to active projects" section of this blog post gives a good sense.

@cosmomeese

This comment was marked as outdated.

Contributor

cosmomeese commented Apr 20, 2018

Ooooh. This is very helpful - thank you Jenny! :)

@jennybc

This comment was marked as outdated.

Member

jennybc commented Apr 20, 2018

httr is on the list but no one's pushing on it right now.

@cosmomeese

This comment was marked as outdated.

Contributor

cosmomeese commented Apr 20, 2018

Fair enough - like you said, it comes in waves. At least for now I know the tide is out. :P

@hadley

Can you please do a pass over your changes with styler, or by manually following the rules at http://style.tidyverse.org/? It's currently rather hard for me to read the code.

cosmomeese added some commits Nov 22, 2018

Merge commit '5345aaf04486a507f5fcfe028225f4f4d7c8afa6'
# Conflicts:
#	man/init_oauth2.0.Rd
#	man/oauth2.0_token.Rd
Merge branch 'master' into experiment
fixing styler overreach
@cosmomeese

This comment has been minimized.

Contributor

cosmomeese commented Nov 22, 2018

Done - used 'styler' and tweaked manually when it didn't work so well. Let me know if it needs further tweaking.

@hadley

I think the idea is sound. I've made a bunch of suggestions to improve the style.

Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved tests/testthat/test-oauth-query-params.R Outdated
Show resolved Hide resolved tests/testthat/test-oauth-query-params.R Outdated
Show resolved Hide resolved tests/testthat/test-oauth-query-params.R Outdated
Show resolved Hide resolved tests/testthat/test-oauth-query-params.R Outdated
Show resolved Hide resolved tests/testthat/test-oauth-query-params.R Outdated

cosmomeese added some commits Nov 26, 2018

cosmomeese added some commits Nov 26, 2018

@cosmomeese

This comment has been minimized.

Contributor

cosmomeese commented Nov 26, 2018

Done.
Let me know if test_that("oauth2.0 authorize url with empty input does not append empty query params") is clearer (moved to test-oauth.R)

Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved R/oauth-init.R
Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved R/oauth-init.R Outdated
Show resolved Hide resolved tests/testthat/test-oauth.R Outdated
@cosmomeese

This comment has been minimized.

Contributor

cosmomeese commented Nov 27, 2018

Done. Replaced the empty input test with something that's hopefully clearer, more concise and more useful.

@hadley

Looks great. One last thing: can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

cosmomeese added some commits Nov 28, 2018

@cosmomeese

This comment has been minimized.

Contributor

cosmomeese commented Nov 28, 2018

Done - let me know if it's too wordy (or should be split up into more bullets).

@hadley hadley merged commit 4529493 into r-lib:master Dec 4, 2018

3 checks passed

codecov/patch 56.25% of diff hit (target 46.54%)
Details
codecov/project 47.07% (+0.53%) compared to 66a48cb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Dec 4, 2018

Thanks!

@cosmomeese

This comment has been minimized.

Contributor

cosmomeese commented Dec 4, 2018

My pleasure - thanks for the all the help & guidance with this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment