New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a demo for one-legged OAuth1 using Noun Project API #548

Merged
merged 8 commits into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@cderv
Contributor

cderv commented Nov 24, 2018

This closes #542 by providing a demo on using oauth_signature to use an OAuth1.0a One legged API.

cderv added some commits Nov 24, 2018

add a demo for one-legged OAuth1
using Noun Project API (#542)
@cderv

This comment has been minimized.

Contributor

cderv commented Nov 24, 2018

Unfortunately, I am not sure how to do for demo to provide Key and Secret. I think demo files are run at built time, or at least can be run using demo().

Currently I left the Sys.getenv but it won't work unless the user register himself and add the env to Renviron. It this ok ?

@hadley

This comment has been minimized.

Member

hadley commented Dec 4, 2018

Maybe use rstudioapi::askForPassword() instead of Sys.getenv()? Then it's one it's a bit more direct for the user.

You don't need to worry about the demos being automatically rerun.

# https://thenounproject.com/accounts/login/?next=/developers/apps/
# Add the below environment variable to your session
# (helper function : usethis::edit_r_environ())
nouns_app <- oauth_app("noun_project",

This comment has been minimized.

@hadley

hadley Dec 4, 2018

Member

Would you mind using the standard tidyverse style here?

@hadley

This comment has been minimized.

Member

hadley commented Dec 4, 2018

Actually, let me just finish this off since the changes are small and I need to practice my contributing back to PR skills

@hadley hadley merged commit e21943e into r-lib:master Dec 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@hadley

This comment has been minimized.

Member

hadley commented Dec 4, 2018

Thanks @cderv!

@cderv

This comment has been minimized.

Contributor

cderv commented Dec 4, 2018

Thanks!
I really need to study and take care of the tidyverse style to stop having reviews about it 😉

@cderv cderv deleted the cderv:fix-542-add-demo branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment