Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RETRY() error-handling #581

Merged
merged 1 commit into from Apr 1, 2019

Conversation

@austin3dickey
Copy link
Contributor

commented Apr 1, 2019

This PR fixes a few issues where an unsuccessful request_perform() during a RETRY() will prematurely fatal with the following error message:

Error in UseMethod("http_error") : no applicable method for 'http_error' applied to an object of class "c('simpleError', 'error', 'condition')"

Now, RETRY() will successfully retry in those cases. This fix was @hadley 's suggestion.

Fixes #569
Fixes #574

Austin Dickey

@hadley hadley merged commit 0dc7559 into r-lib:master Apr 1, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@hadley

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thanks!

@jameslamb jameslamb referenced this pull request Apr 9, 2019

Merged

Fix flaky RETRY unit test #586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.