Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override the CA bundle #603

Merged
merged 1 commit into from Jul 27, 2019

Conversation

@jeroen
Copy link
Member

commented Jul 27, 2019

Manually setting cainfo has long been redundant (the curl package takes care of this if needed).

Unfortunately in the latest versions of libcurl (now on CRAN) overriding the cainfo on Windows actually breaks the corporate Windows certs. So we may need a hotfix release for this.

See issue here: jeroen/curl#193

Do not override the CA bundle
It is not needed and on recent versions of libcurl this actually replaces corporate Windows certs

@jeroen jeroen merged commit 5b9ebfa into master Jul 27, 2019

4 checks passed

codecov/patch 100% of diff hit (target 47.98%)
Details
codecov/project Absolute coverage decreased by -0.15% but relative coverage increased by +52.01% compared to 436d97f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jeroen jeroen deleted the cainfo branch Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.