Stacking queries in req_url_query()

[jl5000]

In some APIs, such as for Jive, you can stack query parameters with the same name and differentiate them in the values, however the default behaviour of httr2 seems to be to overwrite them if they have the same name, e.g.:

httr2::req_url_query(req, filter = "name(Hadley)", filter = "company(rstudio)")

Would it be worth adding a parameter to switch off this behaviour?

[lmkirvan]

I'll second this. I have this same issue with an elastic search API.
It looks like the default is only to take the second of two query parameters with the same name. Even if you don't want to allow this behavior for some reason, I think adding a warning that one is being dropped makes sense, otherwise this will provide incorrect results without a warning.

For others with this issue modify_list is the culprit. I added a masking req_url_query function in my package where parameters are added with c instead of .x [names(dots)] <- dots and it works.

I'm sure this would break all kinds of stuff if changed globally but maybe it can work for others with the same issue.

[hadley]

Reprex:

library(httr2)

request("https://test.com") |> 
  req_url_query(filter = "X", filter = "Y") 
#> <httr2_request>
#> GET https://test.com?filter=Y
#> Body: empty

^{Created on 2022-04-26 by the reprex package (v2.0.1)}