Better error message in req_retry()
#392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthegeek
approved these changes
Nov 14, 2023
Contributor
jonthegeek
left a comment
jonthegeek
left a comment
There was a problem hiding this comment.
Clear error messages are very helpful!
| if (!is_number_or_na(after)) { | ||
| not <- obj_type_friendly(after) | ||
| cli::cli_abort( | ||
| "The {.code after} callback to {.fn req_retry} must return a single number or NA, not {not}.", |
Contributor
There was a problem hiding this comment.
Out of curiosity, why not, vs this?
Suggested change
| "The {.code after} callback to {.fn req_retry} must return a single number or NA, not {not}.", | |
| "The {.code after} callback to {.fn req_retry} must return a single number or NA, not {.obj_type_friendly {after}}.", |
Member
Author
There was a problem hiding this comment.
Just to make the lines shorter.
Contributor
There was a problem hiding this comment.
Aha! I thought that might be it, but the GitHub web UI made it not look THAT long. Glad to know I wasn't missing something!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385