aws_v4_signature bugfix#645
Merged
Merged
Conversation
…ment to query-build before being defined.
Member
|
Oops 😬 Would you mind adding a test too? |
Contributor
Author
|
I thought about it, but couldn't think of a way to add a test without hard-coding some sort of AWS authentication tokens. The best that I could come up with is to test the output of aws_v4_signature with a fixed set of arguments, including the timestamp, but that wouldn't test the actual authentication with AWS. Would that be good enough? |
Member
|
Yeah, I think that would be good enough, given that the previous code wouldn't even run. |
added 2 commits
January 23, 2025 10:47
Contributor
Author
|
Added the requested test of aws_v4_signature |
Member
|
Thanks! I switched your test to use a snapshot test, since the values aren't so important here and just clutter up the test file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug where 'CanonicalQueryString' was used as an argument to query-build before being defined, instead of 'sorted_query'. Before, using the function req_auth_aws_v4 would result in the error 'object 'CanonicalQueryString' not found'.