From 698148e29abfc7760f0e9641be8bddcc76a7a9ef Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Fri, 24 Oct 2025 09:56:57 +0100 Subject: [PATCH 1/2] Use withCallingHandlers instead of tryCatch --- R/req-promise.R | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/R/req-promise.R b/R/req-promise.R index a3523118..17ca03e8 100644 --- a/R/req-promise.R +++ b/R/req-promise.R @@ -117,7 +117,7 @@ ensure_pool_poller <- function(pool, reject) { } poll_pool <- function(ready) { - tryCatch( + withCallingHandlers( { status <- curl::multi_run(0, pool = pool) if (status$pending > 0) { @@ -135,7 +135,6 @@ ensure_pool_poller <- function(pool, reject) { }, error = function(cnd) { monitor$ending() - reject(cnd) } ) } From b4b80216958df68a85c33e27f944edec4ea8df06 Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Fri, 24 Oct 2025 10:08:34 +0100 Subject: [PATCH 2/2] Remove unneeded argument --- R/req-promise.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/req-promise.R b/R/req-promise.R index 17ca03e8..dab298c3 100644 --- a/R/req-promise.R +++ b/R/req-promise.R @@ -106,11 +106,11 @@ req_perform_promise <- function( mock = mock ) pooled_req$submit(pool) - ensure_pool_poller(pool, reject) + ensure_pool_poller(pool) }) } -ensure_pool_poller <- function(pool, reject) { +ensure_pool_poller <- function(pool) { monitor <- pool_poller_monitor(pool) if (monitor$already_going()) { return()